Conversation
[ci skip]
Owner
Author
|
This highlights the first issue (Minor, but there we go).... Vector2 and Vector3 have the == operator defined, but not the Equals. Michelle didn't implement this one, can't see a good reason why at the minute, but the compiler warning was specifically disabled. |
leezer3
force-pushed
the
UnitTests
branch
2 times, most recently
from
5ceb1b1 to
7b5406d
Compare
Owner
Author
|
Operators added, and cherry-picked onto the main branch for good measure. Checking with the debugger, these are unused (presumably why not implemented), but using the default CLR comparisons would produce unintended results. |
Owner
Author
|
Same issue with Colors regarding operators, will try and deal with those at some point soonish. |
leezer3
force-pushed
the
master
branch
4 times, most recently
from
b734a52 to
3f5ad6a
Compare
leezer3
force-pushed
the
master
branch
5 times, most recently
from
bad6395 to
438f090
Compare
leezer3
force-pushed
the
master
branch
3 times, most recently
from
5f23a6d to
a53fd14
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[ci skip]
WIP for adding unit tests for our API types, just basic addition, subtraction and negation for Vector3 at the minute.
Whilst (as far as I know....) everything works as expected, once completed this will hopefully stop stupid bugs from creeping in.
Specifically, stuff like some of the more custom string parsing functions (to times etc.) would be useful to be tested, as several oddities have been fixed in this.