Skip to content

Add per-SiPM PE sums for prompt and delayed LAr coincidence windows#41

Open
jonasschlegel wants to merge 1 commit into
mainfrom
sipm_window_prompt_delayed
Open

Add per-SiPM PE sums for prompt and delayed LAr coincidence windows#41
jonasschlegel wants to merge 1 commit into
mainfrom
sipm_window_prompt_delayed

Conversation

@jonasschlegel

Copy link
Copy Markdown
Contributor

Extend the SiPM-side LAr cut to compute per-channel PE sums separately for the prompt and delayed coincidence windows (already exluding DC tags in +/-300 window (config), so downstream cuts can be tuned per window without recomputing the sums (need for ML-based-LAr veto). Lar cut, event pe sum und multiplicty still evaluated with full window -1 to 5 mus from config, but promt, delayed and full window are now written in ged_spms group.

Per-event ged_spm/ft_spm now expose VoV columns with the pe_sum per SiPM
fiber for the existing LAr window plus two new windows (prompt, delayed)
configured via ged_sum_window_prompt/delayed in the evt config. No new
event-level cut for prompt/delayed — only the raw per-fiber values.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@jonasschlegel jonasschlegel self-assigned this Apr 28, 2026
@jonasschlegel jonasschlegel added the enhancement New feature or request label Apr 28, 2026
@codecov

codecov Bot commented Apr 28, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 38 lines in your changes missing coverage. Please review.
✅ Project coverage is 5.26%. Comparing base (52d9a5e) to head (6a5408e).

Files with missing lines Patch % Lines
src/calibrate_smps.jl 0.00% 38 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main     #41      +/-   ##
========================================
- Coverage   5.77%   5.26%   -0.52%     
========================================
  Files          7       7              
  Lines        329     361      +32     
========================================
  Hits          19      19              
- Misses       310     342      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants