Fix linting and formatting setup#401
Open
JulesBlm wants to merge 5 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linting
This PR fixes ESLint config and updates linting dependencies.
The project had ESLint 9 installed but still used the legacy
.eslintrc.cjs+.eslintignore. ESLint 9+ only reads flat config (eslint.config.js), so it errored out immediately with "couldn't find an eslint.config file". The old config also referenced plugins (svelte3, @typescript-eslint) that were no longer installed.Running ESLint now surface 780 errors, 46 warnings. Of these 124 errors are potentially autofixable. I'm leaving that for another PR.
Formatting
Updates prettier and prettier-plugin-svelte. Adds prettier-plugin-svelte to the prettier config so it works when run from CLI.
VS Code config
Add VS Code config files to Prettier becomes the default formatter for VS Code for this repo so we have one consistent way of formatting.