[Fix] Prevent numeric 100 hp turning into percents#73
Open
Remuchi wants to merge 1 commit intolejeffe:masterfrom
Open
[Fix] Prevent numeric 100 hp turning into percents#73Remuchi wants to merge 1 commit intolejeffe:masterfrom
Remuchi wants to merge 1 commit intolejeffe:masterfrom
Conversation
Signed-off-by: Remuchi <RemuchiOfficial@gmail.com>
Collaborator
|
Hello thanks for taking the time to write a fix, this indeed is a very niche problem that occurs due to the That said i think i'll add a more proper way of dealing with this and give you credits. 😄 👍 |
xines
added a commit
to xines/MonsterHP
that referenced
this pull request
Mar 28, 2026
…for the find. Switched math rounding down to nearest, if this is becomes a issue we can easly patch. Also implements per npc low health color support, that i somehow forgot to submit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the plugin checked if monster had exactly 100 hp as being "default", it let to the issue that made monsters hp jump e.g. 120 -> 40 -> 90. Now it's displayed correctly and default hp value was changed to -1 for consistency with RuneLite's
Actorclass.