Enhanced logging, UI adjustments, and event handling.#20
Merged
lekoala merged 1 commit intolekoala:masterfrom Apr 11, 2025
Merged
Enhanced logging, UI adjustments, and event handling.#20lekoala merged 1 commit intolekoala:masterfrom
lekoala merged 1 commit intolekoala:masterfrom
Conversation
- Added `rowRendered` event for table row rendering. - Adjusted button `margin-left` in `_actions.scss`. - Commented out `min-width` in `_core.scss` to fix layout issues. - Changed `log` method in `base-element.js` to accept an array. - Wrapped `loadData` method call in `DataGrid` and `SaveState` with `setTimeout` for plugin readiness. - Added detailed logging in `DataGrid` methods. - Improved logging and state handling in `SaveState` class.
Owner
|
hi @jackkjhsu this is looking good i'm going to do some quick checks and publish it |
Contributor
Author
|
Thank you so much Thomas! |
Contributor
Author
|
Also Thomas, could we push this new build to npm when you have a chance? Thank you again. |
Owner
|
@jackkjhsu yes there was an issue earlier with npm but now its working |
Contributor
Author
|
Awesome! Thanks again Thomas. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Thomas,
I hope you're doing well these days. Another round changes as follows. I'm including @fiztech-code for awareness.
Please let me know if these are ok. Thanks!
rowRenderedevent for table row rendering.margin-leftin_actions.scss.min-widthin_core.scssto fix layout issues.logmethod inbase-element.jsto accept an array.loadDatamethod call inDataGridandSaveStatewithsetTimeoutfor plugin readiness.DataGridmethods.SaveStateclass.