Remove binary files

[mldulaney]

Open source software should, by definition, not be distributing binary files. Given the xz backdoor, these increase distrust.

[psionic-k]

Hello there, fellow Gentoo stage 1 user?

[vindarel]

thanks, we will merge this.

I'll wait a bit and look at our options to automate the build.

(Anyone is welcome to help)

[mldulaney]

thanks, we will merge this.

I'll wait a bit and look at our options to automate the build.

(Anyone is welcome to help)

hi, how are these binaries built? i'd be happy to help set them up to build with the rest of lem at build time

[vindarel]

@mldulaney hey thanks for proposing.

Here's a lisp snippet that builds the binary:

;; thanks to April & May on Discord
(let* ((source (asdf:system-relative-pathname :lem-terminal "terminal.c"))
       (lib (asdf:system-relative-pathname
             :lem-terminal (format nil
                                   "~(lib/~A/~A/terminal.so~)"
                                   (uiop:operating-system)
                                   (uiop:architecture)))))
  (unless (probe-file lib)
    (ensure-directories-exist lib)
    #+darwin
    (uiop:run-program (format nil "cc ~A -I/opt/homebrew/include -L/opt/homebrew/lib -lvterm -o ~A -shared -fPIC" 
                              source lib))
    #-darwin
    (uiop:run-program (format nil "cc ~A -lvterm -o ~A -shared -fPIC" source lib))))

(it fails on my machine so it's a bit more difficult to test for me)

Example invocation:

cc /home/vindarel/lisp-projects/lem/extensions/terminal/terminal.c -lvterm -o /home/vindarel/lisp-projects/lem/extensions/terminal/lib/linux/x64/terminal.so -shared -fPIC

terminal.c:297:34: error: ‘VTermScreenCellAttrs’ has no member named ‘conceal’
  297 |   return terminal->lastCell.attrs.conceal;
[…]

[jgarte]

Here's some other relevant building code for this:

be73d0d#commitcomment-173429479

https://codeberg.org/guix/guix/src/commit/1434b4e6c78cf47ae0611a079098ef392cc2ea92/gnu/packages/text-editors.scm#L287

(invoke #$(cc-for-target)
                        "extensions/terminal/terminal.c"
                        "-L"
                        lib-dir
                        "-lvterm"
                        "-Wl,-Bdynamic"
                        "-o"
                        shared-lib
                        "-shared"
                        "-fPIC"
                        "-lutil"))

[jgarte]

Here's a lisp snippet that builds the binary:

@vindarel Should your build script example be added to the scripts directory, not unlike scripts/build-legit.lisp and then a top-level Makefile target added?

https://github.com/lem-project/lem/blob/main/Makefile#L44

[vindarel]

@jgarte mmh maybe it could, so one could run this build step on its own; but most importantly the build step that builds Lem on the CI should run it and include the final .so in the bundle. I also think building this .so is optional and shouldn't make all the build fail.

also the snippet is courtesy of a helping hand on Discord

[ra-id-j]

Comment on the build snippet:
#2060 (comment)
I will collect all comments in the discussion thread linked above.