chore: ignore .lt-dev/ and persist the reviewer learnings from the 11.28.0 review#562
Merged
Conversation
….28.0 review
Two unrelated bits of housekeeping that were sitting in the working tree.
**.gitignore** — `.lt-dev/` is created per worktree by the `lt dev` CLI and has no business being
tracked.
**.claude/agent-memory/** — written by the review agents during the 11.28.0 (401/403) review. These
are the findings worth carrying forward, not the review prose:
- `security-reviewer/project-exception-wire-format.md` — `HttpExceptionLogFilter` serializes
`{ ...exception }` for REST, so a custom `HttpException` subclass silently changes the wire body
(`name`, `options`) AND breaks `instanceof` against the native Nest exceptions. This is the finding
that would otherwise have shipped a silent breaking change in #559.
- `backend-reviewer/project_401-403-denial-surface.md` — the framework has five permission-denial
layers, and they used to contradict each other. A change to one is a change to none.
- `docs-reviewer/release-version-artifacts.md` — `spectaql.yml` carries the version too and is
derived from `package.json`, but only by `pnpm run docs`, never by `build`. It is therefore
reliably forgotten in release commits.
- `test-reviewer/e2e-isolation-model.md` — e2e files share ONE database per run and execute in
parallel forks, so any unscoped write to global state (a `jwks` wipe, a config mutation) strands
the other files. Pair-run to reproduce; an isolated re-run proves nothing.
Kept separate from #559 and #561 on purpose: neither is part of a code change.
kaihaase
force-pushed
the
chore/review-hygiene
branch
from
July 15, 2026 08:42
ac8d127 to
8741c93
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two unrelated bits of housekeeping that were sitting in the working tree. Kept out of #559 and #561 on purpose — neither is part of a code change.
.gitignore.lt-dev/is created per worktree by thelt devCLI and has no business being tracked..claude/agent-memory/Written by the review agents during the 11.28.0 (401/403) review. These are the findings worth carrying forward — not the review prose:
security-reviewer/project-exception-wire-format.mdHttpExceptionLogFilterserializes{ ...exception }for REST, so a customHttpExceptionsubclass silently changes the wire body (name,options) and breaksinstanceofagainst the native Nest exceptions. This is the finding that would otherwise have shipped a silent breaking change in #559.backend-reviewer/project_401-403-denial-surface.mddocs-reviewer/release-version-artifacts.mdspectaql.ymlcarries the version too and is derived frompackage.json— but only bypnpm run docs, never bybuild. It is therefore reliably forgotten in release commits.test-reviewer/e2e-isolation-model.mdjwkswipe, a config mutation) strands the other files. Pair-run to reproduce; an isolated re-run proves nothing.🤖 Generated with Claude Code