Filter negative gains in NDCG calculation#1065
Merged
mdekstrand merged 6 commits intolenskit:mainfrom Apr 7, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1065 +/- ##
=======================================
Coverage 89.45% 89.46%
=======================================
Files 233 233
Lines 15870 15874 +4
=======================================
+ Hits 14197 14201 +4
Misses 1673 1673 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mdekstrand
approved these changes
Apr 6, 2026
Comment on lines
+116
to
+117
| if ideal == 0: | ||
| return 0.0 |
Member
There was a problem hiding this comment.
yeah this is probably a good idea.
Member
|
Can we add a note on clipping the gains to the documentation? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thi PR resolves #1057 by clipping negative gains to zero in both the computed DCG and the ideal DCG.