Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request reorganizes the documentation structure by renaming sections, updating navigation links, and introducing a new benchmark landing page. Key changes include removing header numbering and refining terminology across the C#, Python, and theory guides. Review feedback identifies an inconsistency in the reported number of Python libraries, a grammatical error in the theory section where 'Span' was omitted, and a duplicate description for the Selection Guide entry.
|
|
||
| * **The Problem:** Naive serializers allocate new arrays and strings for every field they parse. | ||
| * **The Solution:** Modern serializers utilize **Zero-Allocation** techniques. They deserialize directly into pre-allocated buffers or use span-like structures (e.g., C#'s `Span<T>`) to reference existing memory rather than copying it. | ||
| * **The Solution:** Modern serializers utilize **Zero-Allocation** techniques. They deserialize directly into pre-allocated buffers or use span-like structures (e.g., C#'s) to reference existing memory rather than copying it. |
Contributor
There was a problem hiding this comment.
The reference to Span seems to have been accidentally removed, leaving the sentence grammatically incomplete ('e.g., C#'s'). It's better to keep the specific example for clarity.
Suggested change
| * **The Solution:** Modern serializers utilize **Zero-Allocation** techniques. They deserialize directly into pre-allocated buffers or use span-like structures (e.g., C#'s) to reference existing memory rather than copying it. | |
| * **The Solution:** Modern serializers utilize **Zero-Allocation** techniques. They deserialize directly into pre-allocated buffers or use span-like structures (e.g., C# Span<T>) to reference existing memory rather than copying it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.