Skip to content

Fix/docs root#26

Merged
leo-gan merged 3 commits intomasterfrom
fix/docs-root
May 1, 2026
Merged

Fix/docs root#26
leo-gan merged 3 commits intomasterfrom
fix/docs-root

Conversation

@leo-gan
Copy link
Copy Markdown
Owner

@leo-gan leo-gan commented May 1, 2026

No description provided.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request reorganizes the documentation structure by renaming sections, updating navigation links, and introducing a new benchmark landing page. Key changes include removing header numbering and refining terminology across the C#, Python, and theory guides. Review feedback identifies an inconsistency in the reported number of Python libraries, a grammatical error in the theory section where 'Span' was omitted, and a duplicate description for the Selection Guide entry.

Comment thread docs/analysis/index.md
Comment thread docs/theory/index.md Outdated

* **The Problem:** Naive serializers allocate new arrays and strings for every field they parse.
* **The Solution:** Modern serializers utilize **Zero-Allocation** techniques. They deserialize directly into pre-allocated buffers or use span-like structures (e.g., C#'s `Span<T>`) to reference existing memory rather than copying it.
* **The Solution:** Modern serializers utilize **Zero-Allocation** techniques. They deserialize directly into pre-allocated buffers or use span-like structures (e.g., C#'s) to reference existing memory rather than copying it.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The reference to Span seems to have been accidentally removed, leaving the sentence grammatically incomplete ('e.g., C#'s'). It's better to keep the specific example for clarity.

Suggested change
* **The Solution:** Modern serializers utilize **Zero-Allocation** techniques. They deserialize directly into pre-allocated buffers or use span-like structures (e.g., C#'s) to reference existing memory rather than copying it.
* **The Solution:** Modern serializers utilize **Zero-Allocation** techniques. They deserialize directly into pre-allocated buffers or use span-like structures (e.g., C# Span<T>) to reference existing memory rather than copying it.

Comment thread docs/theory/index.md Outdated
@leo-gan leo-gan merged commit 824367e into master May 1, 2026
4 checks passed
@leo-gan leo-gan deleted the fix/docs-root branch May 1, 2026 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant