Skip to content

fix/analysis cross language#29

Merged
leo-gan merged 10 commits intomasterfrom
fix/analysis-cross-language
May 2, 2026
Merged

fix/analysis cross language#29
leo-gan merged 10 commits intomasterfrom
fix/analysis-cross-language

Conversation

@leo-gan
Copy link
Copy Markdown
Owner

@leo-gan leo-gan commented May 2, 2026

Title: Remove cross-language analysis and clean up documentation structure

Summary:
This PR removes all cross-language comparison features and eliminates orphaned documentation files. The benchmark now focuses exclusively on same-language serializer comparisons (C# vs C#, Python vs Python).

Changes:

Code Changes:

  • analysis/src/benchmark_analysis/reports.py: Removed cross-language data preparation, multidimensional analysis sections, and cross-language comparison tables from both Markdown and HTML report generators
  • Changed HTML dashboard subtitle from "Cross-language serialization performance comparison" to "Serialization performance comparison"
  • Regenerated docs/analysis/BENCHMARK_SUMMARY.md and dashboard to contain only pivot tables

Documentation Cleanup:

  • Removed docs/_config.yml (Jekyll config - project uses MkDocs)
  • Removed orphaned docs/*.md files: benchmark-results.md, getting-started.md, methodology.md
  • Removed duplicate analysis/docs/ folder (outdated copies)
  • Removed analysis/reports/ folder (generated outputs now only in docs/analysis/)
  • Updated docs/analysis/ANALYSIS_METHODOLOGY.md: Removed "Multidimensional Analysis" and "Cross-Language" sections
  • Updated docs/analysis/serialization_categories.md: Made observations language-neutral

Result:

  • Cleaner codebase focused on per-language analysis
  • Single source of truth for documentation in docs/
  • MkDocs site builds without orphaned pages

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request streamlines the benchmark reporting system by removing detailed per-language tables, top performer comparisons, and multidimensional analysis from both the generated Markdown summaries and the HTML dashboard. It also simplifies the documentation by removing several files, including the Jekyll configuration and references to the Jupyter notebook. Feedback indicates that the methodology documentation should still describe the HTML dashboard features since they are still being generated, and identifies a typo and a spacing issue in the updated documentation files.

Comment thread docs/analysis/ANALYSIS_METHODOLOGY.md
Comment thread docs/analysis/index.md Outdated
Comment thread docs/analysis/violin-plots.md Outdated
@leo-gan leo-gan merged commit d34739a into master May 2, 2026
4 checks passed
@leo-gan leo-gan deleted the fix/analysis-cross-language branch May 2, 2026 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant