Conversation
sproshev
approved these changes
Oct 30, 2018
sproshev
left a comment
sproshev
left a comment
There was a problem hiding this comment.
зачтено с замечаниями по reset/content/checkout, исправить можно в 3
| import java.io.*; | ||
| import java.nio.charset.StandardCharsets; | ||
|
|
||
| public class Message { |
|
|
||
| public void print() { | ||
| System.out.print(read()); | ||
| } |
|
|
||
| public BlobType type; | ||
| public String name; | ||
| public InputStream content; |
There was a problem hiding this comment.
лучше путь или что-то такое, что точно не хранит в себе системные ресурсы, а здесь может быть поток с открытым файловым дескриптором
и он нигде не закрывается (((
| return include; | ||
| } | ||
| } | ||
| ).collect(Collectors.toList()); |
| GitFileKeeper.clearDirectory(tree.index()); | ||
| fileKeeper.restoreCommit(references, tree.index()); | ||
| clerk.changeHeadInfo(revision); | ||
| return new CommandResult(ExitStatus.SUCCESS, "reset: done!"); |
| if (!GitFileKeeper.checkFilesExist(files)) { | ||
| return new CommandResult(ExitStatus.FAILURE, ""); | ||
| } | ||
| GitFileKeeper.copyAll(files, tree.index(), tree.repo()); |
There was a problem hiding this comment.
checkout должен происходить не из индекса, а storage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.