Use StringBuilder instead of string concatenation in loop#97
Closed
dariuszzbyrad wants to merge 4 commits into
Closed
Use StringBuilder instead of string concatenation in loop#97dariuszzbyrad wants to merge 4 commits into
dariuszzbyrad wants to merge 4 commits into
Conversation
Open
lessthanoptimal
self-requested a review
October 6, 2020 14:28
lessthanoptimal
approved these changes
Oct 6, 2020
Owner
|
Thanks! I ended up needing to manually merge it because of the non-linear history. Makes it a lot easier if you squash and rebase off the latest SNAPSHOT. https://blog.carbonfive.com/always-squash-and-rebase-your-git-commits/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted part of the CR #89