Allow GH user to exist without having TODO before it#63
Allow GH user to exist without having TODO before it#63ahmedelgabri wants to merge 2 commits intolewis6991:mainfrom
Conversation
| local function get_user() | ||
| local WORD = fn.expand('<cWORD>') | ||
| local user = WORD:match('TODO%(@?(.*)%):') | ||
| local user = WORD:match '%f[%w_]@?(.*)%f[^%w_]' |
There was a problem hiding this comment.
What is this expected to match in practice? Some comments would help.
There was a problem hiding this comment.
I don't think the regex is perfect, but it matches @user and user, the %f[%w_] and %f[^%w_] is because of the lack of \b in Lua. https://stackoverflow.com/a/32854326/213124
There was a problem hiding this comment.
This will cause a lot of false-positives as most words exist as a gihutb user.
There was a problem hiding this comment.
The plugin depends on an explicit action (moving the cursor on a word and then triggering the hover) so the false-positives would be minimal. But we can make the @ mandatory too, so it matches only @user
There was a problem hiding this comment.
The plugin depends on an explicit action (moving the cursor on a word and then triggering the hover) so the false-positives would be minimal.
Maybe that reflects how you use the plugin, but I use this with the dictionary provider and I don't want to be viewing github users as the first result when I want the definition for a word.
There was a problem hiding this comment.
Making @ mandatory instead of optional might be a good middle ground then?
2 participants
I dunno what's the reason for having
TODO(@user)orTODO(user)as a requirement to get GH user information, but I don't think that's needed, and making it generic will allow it to work more contexts (includingTODO). What do you think?