Model UnlinkPool hashNote via PoseidonT4 boundary#65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Note
Medium Risk
Updates the
UnlinkPoolmodel’s note hashing from placeholder arithmetic to a newposeidonT4external boundary, which can affect any logic/proofs depending on commitment values. Remaining changes are task/manifest metadata updates with low runtime impact.Overview
Models
UnlinkPool.hashNoteas a real cryptographic boundary call by adding a linked externalposeidonT4and routinghashNote(npk, token, amount)throughposeidonT4(npk, uint160(token), amount)instead of placeholder math.Refreshes the
build_greentask template and manifest notes to reflect the updated state of the translation and to track remaining unsupported-feature blockers (including new entries for proxy storage rotation and assumed cryptographic/Permit2/Groth16 axioms).Reviewed by Cursor Bugbot for commit 7859c8d. Bugbot is set up for automated code reviews on this repo. Configure here.