Use hashNote for withdrawal commitment check#66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Note
Medium Risk
Changes the withdrawal commitment validation logic and the ordering of recipient casting/checks, which could affect withdrawal acceptance/rejection if the modeled hash does not match the on-chain contract behavior.
Overview
Updates
executeWithdrawalinBenchmark/Cases/UnlinkXyz/Pool/Contract.leanto derive the withdrawal commitment hash viahashNote(npk, token, amount)instead of a simple arithmetic combination, and compares the withdrawal output slot against this modeled hash.Reorders recipient derivation to occur after the
npkbounds check, keeping the cast/check sequence closer to the upstream Solidity_executeWithdrawal.Reviewed by Cursor Bugbot for commit 2e30ee8. Bugbot is set up for automated code reviews on this repo. Configure here.