Pin Unlink benchmark to merged Verity ergonomics#70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
verity-benchmarkto the merged Verity main commit containing the generic Solidity ergonomics used by UnlinkPoollake-manifest.jsonto the same Verity revisionVerification
lake update veritylake build Benchmark.Cases.UnlinkXyz.Pool.CompileThe build succeeds. Existing unused-variable warnings in
Benchmark/Cases/UnlinkXyz/Pool/Contract.leanare unchanged.Note
Low Risk
Low risk: this only updates the pinned
veritydependency revision inlakefile.lean/lake-manifest.json; any risk is limited to upstream API/behavior changes in that dependency affecting builds.Overview
Updates the
veritydependency pin to commit03447eab...and alignslake-manifest.jsonto the same revision, ensuring the benchmark project builds against the merged Verity ergonomics changes.Reviewed by Cursor Bugbot for commit 35ef4ff. Bugbot is set up for automated code reviews on this repo. Configure here.