Fix box_argc mismatch in sandbox stack initialization#17
Merged
Conversation
Use `nargv` (number of non-NULL arguments) instead of `argc` (which can count past the first NULL arg) to prevent stack corruption during argv/envp parsing. TAG=agy CONV=0190fdf7-8c75-45c1-9535-399f772ca10f
Add a test runner `test_argv_mismatch` and register it in `meson.build` to verify that `lfi_thread_new` correctly handles cases where `argc` is larger than the actual number of arguments (contains trailing NULLs).
Member
|
I wonder if there is any case where the user may want argc to be manually set to a value other than nargv? I can't think of any such case at the moment, but I'll give it a little more thought and then merge otherwise. |
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
nargv(number of non-NULL arguments) instead ofargc(which cancount past the first NULL arg) to prevent stack corruption during
argv/envp parsing.