Open
Conversation
The program name awk clearly clashes with the system awk, and tawk clashes with Thompson AWK.
|
Partially fixed in 7e8a89f. in the clean target, awk is still listed instead of bioawk: clean:
rm -fr a.out *.o *.obj maketab maketab.exe *.bb *.bbg *.da *.gcov *.gcno *.gcda awk ytab.* proctab.c *.dSYMChange to: clean:
rm -fr a.out *.o *.obj maketab maketab.exe *.bb *.bbg *.da *.gcov *.gcno *.gcda bioawk ytab.* proctab.c *.dSYMAlso the manual awk.1 is not renamed to bioawk.1 in the makefile and in the directory structure: SHIP = README FIXES $(SOURCE) ytab[ch].bak makefile \
awk.1 |
ctSkennerton
pushed a commit
to ctSkennerton/bioawk
that referenced
this pull request
May 22, 2019
Because NCHARS is (256+3) cc->cc_func(i) was called with 256, 257 and 258 as argument leading to possible undefined behaviour (at least on NetBSD with non-C locale (e.g. `en_US.UTF-8') this led to only honoring one `[:...:]' character class in bracket expressions). Fix lh3#11
ctSkennerton
pushed a commit
to ctSkennerton/bioawk
that referenced
this pull request
May 22, 2019
Avoid undefined behaviour when using ctype(3) functions in relex() (possible fix for lh3#11)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The program name awk clearly clashes with the system awk, and tawk clashes with Thompson AWK. Most people probably rename these executables. It would be great if this were reflected in the Makefile.