HSS control#12
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a high-side switch (HSS) control system for the Power Distribution Unit, including a generic SPI shift register driver and logic for managing output states and fault handling. The review identified several critical issues: a pin definition conflict in LSOM_S_Pins.h, a missing SPI interrupt callback that would lead to deadlocks, and potential race conditions on the global state variable. Feedback also highlighted endianness concerns during SPI transmission, the non-standard use of emojis in enums, and the need for more precise hardware timing instead of using RTOS task delays.
| #define LSOM_13_PIN GPIO_PIN_2 | ||
| // differs from sheet? | ||
| #define LSOM_13_PORT GPIOC | ||
| #define LSOM_13_PIN GPIO_PIN_12 |
There was a problem hiding this comment.
Assigning LSOM_13_PIN to GPIO_PIN_12 on GPIOC creates a conflict, as this pin is already defined for LSOM_15_PIN (line 39). This will lead to hardware contention if both are initialized or used simultaneously.
2 participants
No description provided.