Regenerate bindings against upstream master (PR #64)#3
Merged
Conversation
Upstream libBeresta merged naming-convention renames (PR #64) after the last regeneration. Re-running the generator against current gen/data renames six functions on the FFI surface (Create -> New family plus BRST_Doc_Date_Now). Verified with the smoke and structural cross-check specs and the CMake binding/check targets on macOS.
Member
Author
|
Thanks 😊 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upstream libBeresta merged the naming-convention renames (libBeresta/libBeresta#64) after the last regeneration of this gem (#2, which tracked upstream PRs libBeresta/libBeresta#58 + libBeresta/libBeresta#60). This PR re-runs the generator against current
gen/data/*.lsp(58 files) to bring the FFI surface back in sync with upstream master.Note: upstream PR libBeresta/libBeresta#63 (image function renames) only touched the C side —
gen/dataalready carried the new names — so the diff here is purely from libBeresta/libBeresta#64.Changes
Six functions renamed on the generated FFI surface (
Create→Newfamily, plus theDoc_-prefixed date constructor):BRST_Date_NowBRST_Doc_Date_NowDateBRST_Doc_Create_ExtGStateBRST_Doc_ExtGState_NewDocExtGStateBRST_Doc_Pattern_Tiling_CreateBRST_Doc_Pattern_Tiling_NewDocPattern,DocPagePatternBRST_Doc_XObject_CreateBRST_Doc_XObject_NewDocXObjectBRST_Page_CreateDestinationBRST_Page_Destination_NewPageRoutinesAlso adds a
[Unreleased]CHANGELOG entry, since these are breaking renames on the low-level surface.No generator changes were needed — this is a pure regeneration.
Verification
Built upstream master (post- libBeresta/libBeresta#64) via CMake and ran the suite on macOS:
gen/jsonpasses (function/enum/pointer/struct counts per file).bindingandchecktargets as well, per the org-wide target convention.