Skip to content

Fix a typo in a test function#109

Open
eerovaher wants to merge 1 commit intoliberfa:masterfrom
eerovaher:viv-call-typo
Open

Fix a typo in a test function#109
eerovaher wants to merge 1 commit intoliberfa:masterfrom
eerovaher:viv-call-typo

Conversation

@eerovaher
Copy link
Copy Markdown

One of the things that happens when pyerfa is built is that the tests in t_erfa_c.c are converted into pytest tests, but an extraneous whitespace in a single line is needlessly complicating that conversion because that line cannot be processed by calling line.removeprefix("viv(") in Python.

@mhvk
Copy link
Copy Markdown
Contributor

mhvk commented Apr 9, 2026

@eerovaher - this is a nice idea, but a problem is that these .c files are direct renames from the corresponding sofa files, so any edits have to be propagated every time SOFA updates its test file. I think it may be better to just do a .replace("viv (", "viv(") or so... Possibly, this can in fact be done in the script that does the renaming...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants