-
Notifications
You must be signed in to change notification settings - Fork 0
Create struct Program + EncodeToAny + DecodeFromAny + AsScalar #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
caiiiycuk
wants to merge
15
commits into
main
Choose a base branch
from
caiiiycuk-wasm
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
ec19583
Replace CreateProgram.bytecode with CreateProgram.program_module
caiiiycuk f99d33d
Create struct Program + EncodeToAny + DecodeFromAny
caiiiycuk 915897d
Update proto; remove PartialEq requirment
caiiiycuk 174cbc2
Turn module: programModule into Option<>
caiiiycuk aac32e0
Add AsScalar for wasm operators
caiiiycuk 487b17c
Add tests for operator AsScalar conversion
caiiiycuk 98f1ddc
Update ToScalar -> Sha3Hash
caiiiycuk 9c072e2
ok_or_else -> context
caiiiycuk 10e8fe1
Rename function_type to type_index in BlockType
caiiiycuk fc3c8f9
Implement AsScalar for Program
caiiiycuk 0f72e94
Implement hashers for some sections
caiiiycuk 93fbaed
cover all sections with hash
caiiiycuk 5db2d2f
add more unit tests
caiiiycuk 8c19bec
refactor unit tests
caiiiycuk 29d77f0
update proto submodule
caiiiycuk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,2 @@ | ||
| * @71104 | ||
| * @caiiiycuk |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,7 @@ | ||
| fn main() -> Result<(), Box<dyn std::error::Error>> { | ||
| tonic_prost_build::compile_protos("proto/libernet.proto")?; | ||
| tonic_prost_build::configure().compile_protos( | ||
| &["proto/libernet.proto", "proto/libernet_wasm.proto"], | ||
| &["proto"], | ||
| )?; | ||
| Ok(()) | ||
| } |
Submodule proto
updated
5 files
| +1 −0 | CODEOWNERS | |
| +3 −1 | libernet.proto | |
| +264 −0 | libernet_wasm.proto | |
| +361 −0 | libernet_wasm_operators.proto | |
| +23 −0 | libernet_wasm_types.proto |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nitpick: did you use
cargo addto add this dependency?cargoshould keep the dependency list alphabetized, which I prefer.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Never used it)) Good to know, thanks)