Added include directories to targets#154
Open
MickaelOnTheWave wants to merge 1 commit intolibfann:masterfrom
Open
Added include directories to targets#154MickaelOnTheWave wants to merge 1 commit intolibfann:masterfrom
MickaelOnTheWave wants to merge 1 commit intolibfann:masterfrom
Conversation
bukka
requested changes
Oct 12, 2025
Member
bukka
left a comment
bukka
left a comment
There was a problem hiding this comment.
Good improvement, thanks.
I think it should probably remove INCLUDE_DIRECTORIES(${CMAKE_CURRENT_SOURCE_DIR}/include) on line 15, right?
| ADD_LIBRARY(fann SHARED ${fann_LIB_SRCS}) | ||
| target_include_directories(fann PUBLIC ${CMAKE_CURRENT_SOURCE_DIR}/include) | ||
| ADD_LIBRARY(fann_static STATIC ${fann_LIB_SRCS}) | ||
| target_include_directories(fann PUBLIC ${CMAKE_CURRENT_SOURCE_DIR}/include) |
Member
There was a problem hiding this comment.
Suggested change
| target_include_directories(fann PUBLIC ${CMAKE_CURRENT_SOURCE_DIR}/include) | |
| target_include_directories(fann_static PUBLIC ${CMAKE_CURRENT_SOURCE_DIR}/include) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added fann include directory to public include directories.
Thus, projects using it can automatically include headers from fann.