Submodule changes to support query params in add drive#19
Open
armanamjad wants to merge 6 commits intolibguestfs:masterfrom
Open
Submodule changes to support query params in add drive#19armanamjad wants to merge 6 commits intolibguestfs:masterfrom
armanamjad wants to merge 6 commits intolibguestfs:masterfrom
Conversation
Update with latest libguestfs changes
Member
|
Why are there 2 merge commits? What I assume is the main commit (although it is dated 2023) has no description at all. |
Author
I am not sure where those are coming from as well, on my end I only see one commit in this fork's master branch: Could be an issue with submodule |
Author
|
@rwmjones Do the changes in the submodule look good? Let me know if there's anything I should update |
Author
|
Hi @rwmjones could you please take a look at this PR and let me know if you have any other feedback? |
rwmjones
reviewed
Oct 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently query parameters get redacted when connecting to a disk via uri, updated the functions to support an optional query parameter.