Skip to content

remove legacy mDNS implementation#1192

Merged
marten-seemann merged 1 commit intomasterfrom
remove-legacy-mdns
Jun 20, 2022
Merged

remove legacy mDNS implementation#1192
marten-seemann merged 1 commit intomasterfrom
remove-legacy-mdns

Conversation

@marten-seemann
Copy link
Copy Markdown
Contributor

@marten-seemann marten-seemann commented Sep 19, 2021

No description provided.

@marten-seemann marten-seemann force-pushed the remove-legacy-mdns branch 2 times, most recently from c858f5f to 2bdb7a6 Compare September 19, 2021 09:57
@Stebalien
Copy link
Copy Markdown
Member

Stebalien commented Sep 19, 2021

Is there any reason not to leave this around for a while?

@marten-seemann
Copy link
Copy Markdown
Contributor Author

marten-seemann commented Sep 19, 2021

Other than cleaning up code, not really. This is a fairly isolated change, so I'm ok with letting this sit around for a while.

@BigLep BigLep requested a review from a team October 24, 2021 04:35
@BigLep
Copy link
Copy Markdown
Contributor

BigLep commented Oct 24, 2021

Given it's been a month+, can we remove now?

@marten-seemann
Copy link
Copy Markdown
Contributor Author

marten-seemann commented Oct 24, 2021

Given it's been a month+, can we remove now?

No. The new mDNS implementation released in v0.15.0 was kind of buggy, so we'll have to wait before we phase out the old one a little longer.

@mcmxcdev mcmxcdev mentioned this pull request Jan 5, 2022
Merged
7 tasks
@marten-seemann
Copy link
Copy Markdown
Contributor Author

marten-seemann commented Jun 20, 2022

IPFS is removing legacy mDNS support in ipfs/kubo#9048. With our main legacy-mDNS customer gone, there's no need to keep this code around any longer.

@marten-seemann marten-seemann requested a review from MarcoPolo June 20, 2022 08:26
@marten-seemann marten-seemann mentioned this pull request Jun 20, 2022
Closed
41 tasks
@marten-seemann marten-seemann merged commit 707100a into master Jun 20, 2022
MarcoPolo pushed a commit that referenced this pull request Jun 24, 2022
@marten-seemann @MarcoPolo
remove legacy mDNS implementation (#1192)
9d1e699
@marten-seemann marten-seemann deleted the remove-legacy-mdns branch June 26, 2022 10:36
@ajnavarro ajnavarro mentioned this pull request Aug 24, 2022
Closed
72 tasks
@qdm12
Copy link
Copy Markdown

qdm12 commented Aug 31, 2022 •
edited
Loading

Hello here, I am having trouble upgrading from mdns_legacy to mdns in the Go Polkadot host Gossamer, I tried:

https://github.com/ChainSafe/gossamer/pull/2788/files#diff-9603d26d1ec8aa880ef24f64c01d9292bd21c3538eea0b06662c38220d831eddL47-R52

Does anyone has a better clue how to bump this further?

EDIT: MDNS upgrade focused PR ➡️ ChainSafe/gossamer#2794

@Stebalien
Copy link
Copy Markdown
Member

Stebalien commented Aug 31, 2022

Not without knowing what the issue is... Let's move this conversation over to that PR (tag me there and let me know what's up).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vyzo vyzo vyzo approved these changes

@lidel lidel lidel approved these changes

@Stebalien Stebalien Stebalien approved these changes

@MarcoPolo MarcoPolo Awaiting requested review from MarcoPolo

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@marten-seemann @Stebalien @BigLep @qdm12 @vyzo @lidel