fix: correct stream handling and protocol dialing in example code#207
Open
sumanjeet0012 wants to merge 2 commits intolibp2p:mainfrom
Open
fix: correct stream handling and protocol dialing in example code#207sumanjeet0012 wants to merge 2 commits intolibp2p:mainfrom
sumanjeet0012 wants to merge 2 commits intolibp2p:mainfrom
Conversation
39a0329 to
4197ac0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title
fix: correct stream handling and protocol dialing in example code
Description
This PR addresses issues in the commented-out example code that would prevent it from working if uncommented:
Fixed stream data handling: Added
.subarray()when reading from the stream to properly handle buffer data in the active code.Fixed protocol dialing in commented code:
Added missing
awaitkeyword when dialing a protocolChanged from
node2.peerIdtonode2.getMultiaddrs()for correct addressingFixed data encoding in commented code: Added
uint8ArrayFromString()to properly encode string messagesThese changes ensure the example code will work correctly when users uncomment it for their own implementations, providing a reliable reference for libp2p protocol and stream muxing.
Notes & open questions
Change checklist