This repository was archived by the owner on Jul 21, 2023. It is now read-only.
fix: ipv6 naming with multiaddr-to-uri package#81
Merged
Conversation
ghost
assigned
alanshaw
approved these changes
Jan 24, 2019
jacobheun
suggested changes
Jan 24, 2019
jacobheun
left a comment
jacobheun
left a comment
Contributor
There was a problem hiding this comment.
We should get some tests added for this. Currently there are several skipped, empty ipv6 tests. Right now we're only testing filtering. It would be great to get listening and dialing tests in place for at least basic dialing and listening.
Member
Author
|
@jacobheun I agree, I will add those tests |
vasco-santos
force-pushed
the
chore/use-multiaddr-to-uri-package
branch
from
94f7d00 to
b7a9359
Compare
vasco-santos
force-pushed
the
chore/use-multiaddr-to-uri-package
branch
from
b7a9359 to
dd15f5a
Compare
jacobheun
approved these changes
Jan 24, 2019
Contributor
|
This fix is available in v0.12.2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When dht is enabled ipfs/js-ipfs#856, we found an issue where some browser nodes were using ipv6. As soon as we connect them, the connection fails as a result of using an invalid url.
Example:
ws://::1:4002Node
urlimplementation expects a ipv6 address in the following format:ws://[::1]:4002In addition, we do not have to maintain the
multiaddrtourlcode previously here.