fix(gossipsub): prune empty topic entries from topics map#3405
Merged
Conversation
Collaborator
|
moved to blocked - waiting on remaining skipped gossipsub tests |
tabcat
approved these changes
May 11, 2026
Member
tabcat
left a comment
tabcat
left a comment
There was a problem hiding this comment.
Thanks @lodekeeper! nice find!
tabcat
requested changes
May 15, 2026
Member
tabcat
left a comment
tabcat
left a comment
There was a problem hiding this comment.
@lodekeeper just clear the topics in stop() and i think we are good.
| await Promise.all(closePromises) | ||
|
|
||
| this.peers.clear() | ||
| this.subscriptions.clear() |
Contributor
Author
There was a problem hiding this comment.
Added in fb480b5c4 — this.topics.clear() placed right after this.subscriptions.clear(), grouped with the other per-session map resets.
Per tabcat review (libp2p#3405): also reset the topics map alongside the other per-session state in stop() so a restart begins with an empty topic→peer index. 🤖 Generated with AI assistance
Contributor
Author
|
@tabcat addressed in |
tabcat
approved these changes
May 15, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Monorepo port of
ChainSafe/js-libp2p-gossipsub#543.This carries over the empty-topic pruning fix for the internal
topics: Map<TopicStr, Set<PeerIdStr>>bookkeeping:topicsentries on remote unsubscribetopicsentries on peer disconnecttopicsentries from unsubscribe-only updatesOriginal standalone PR / discussion:
ChainSafe/js-libp2p-gossipsub#543Original issue context:
ChainSafe/js-libp2p-gossipsub#542Why reopen here?
wemeetagain asked for this to be reopened against the
js-libp2pmonorepo becausejs-libp2p-gossipsubwill soon be archived.Notes
This is intentionally scoped to
topicsonly. I did not fold in anymeshcleanup changes here becausemeshtracks local joined-topic state and deleting emptymeshtopics on disconnect would interfere with heartbeat maintenance/regrafting.Testing
npm exec --workspace packages/gossipsub -- aegir lintgossip.spec.tsrun currently trips pre-existing monorepo package type/build issues in unrelatedtest/utils/*files; this patch itself is limited topackages/gossipsub/src/gossipsub.tsandpackages/gossipsub/test/gossip.spec.tsAI disclosure
Initial heap analysis and patch drafting were assisted by AI tooling, then validated with local source inspection and review.