fix(kad-dht): only echo PUT_VALUE response on success#3502
Merged
tabcat merged 2 commits intoMay 12, 2026
Conversation
Throw on failure so RPC.handleMessage skips the response write and increments the error metric, matching the spec and go-libp2p.
…-no-echo-on-failure
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The PUT_VALUE handler echoed the request back regardless of whether the record was stored. Per the spec and go-libp2p, the response should only be echoed on successful validation and storage. The handler now throws on failure;
RPC.handleMessagealready catches that to skip the write and increment the error metric.Change checklist