feat: allow async selectors and adding validators/selectors#3506
Open
achingbrain wants to merge 1 commit into
Open
feat: allow async selectors and adding validators/selectors#3506achingbrain wants to merge 1 commit into
achingbrain wants to merge 1 commit into
Conversation
- Allows selector functions to be async similar to validators - Allows adding additional selectors/validators after construction This is to allow extending functionality after setup of other components that have a different lifecycle. Specifically Helia has a libp2p property, but IPNS usage needs setup of Helia before it can add DHT selectors/validators - by that point it's too late to add DHT selectors/validators as libp2p has already been constructed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to allow extending functionality after setup of other components that have a different lifecycle.
Specifically Helia has a libp2p property, but IPNS usage needs setup of Helia before it can add DHT selectors/validators - by that point it's too late to add DHT selectors/validators as libp2p has already been constructed.
Selectors need to be async to allow for more types of work to be done during record selection, here Helia needs to be able to load esoteric encryption schemes that it may not be initially configured with.
Change checklist