Add initial Eclipse attack simulation module with metrics collection by Fatumayattani · Pull Request #950 · libp2p/py-libp2p

Fatumayattani · 2025-09-23T11:25:01Z

What was wrong?

This PR implements the initial setup for the Network Attack Simulation module in py-libp2p, as discussed in [[Discussion #929]] and tracked under Issue #57. The primary focus is on Eclipse attack simulation, building the test network, simulating malicious peers, and establishing the framework for network attack testing.

How was it fixed?

Added tests/security/attack_simulation/ submodule containing:

Eclipse attack:
- malicious_peer.py – Simulates malicious peer behavior
- network_builder.py – Builds test networks with honest and malicious nodes
- metrics_collector.py – Collects attack metrics during simulation
- attack_scenarios.py – Defines different Eclipse attack scenarios
- test_eclipse_simulation.py – Test suite validating network setup and malicious behavior
Utilities:
- Metrics calculation (attack_metrics.py)
- Network monitoring (network_monitor.py)
- Peer behavior simulation (peer_behavior_simulator.py)
- Tests for utilities
Configuration:
- attack_configs.py – Attack configuration options
- network_topologies.py – Predefined network topologies
Added README.md documenting module overview, structure, setup, usage, testing, metrics, roadmap, and Eclipse attack flow (Mermaid diagram)
All tests pass locally (6/6) confirming:
- Network setup works as expected
- Malicious peer behaviors execute correctly
- Metrics collection framework functions properly

To-Do

Clean up commit history if necessary
Add or update documentation related to these changes

Cute Animal Picture

…TLS docs

seetadev · 2025-09-23T15:40:27Z

@Fatumayattani : Thank you for opening the PR on eclipse attack simulation.

Great effort indeed. CCing @acul71, @yashksaini-coder, @bomanaps for their thoughts and feedback. This PR will indeed impact the py-libp2p library.

There is one CI/CD issue too, which is not related to your pull request.

I investigated it and documented it at #949 .

@yashksaini-coder , @sumanjeet0012 and @acul71 are fixing it. We will soon have all the CI/CD tests passing.

@Fatumayattani : Will re-run CI/CD pipeline once the issue is fixed today or tomorrow. In the meantime, assigning you more projects and issues on py-libp2p.

yashksaini-coder · 2025-09-23T19:45:35Z

@Fatumayattani can I get the access for this ?

Fatumayattani · 2025-09-24T06:27:55Z

Thank you @seetadev for the review and for coordinating on the CI/CD issue. I’ll re-run the checks once that’s resolved.

@yashksaini-coder I’ve added you as a collaborator so you now have access to the feature/attack-simulation branch. Please let me know if you face any issues or need anything else to get started.

Really appreciate everyone’s feedback and support in pushing this forward.

…ation files

yashksaini-coder · 2025-09-24T15:13:27Z

@Fatumayattani @seetadev Hi, I've reviewed the PR, and executed the checks and all tests on my end. Everything is good, all test cases passed ✔️ and some new changes to fix the linting and minor errors.

I will work on this for adding more attack simulation and review

…simulation

seetadev · 2025-09-24T17:55:25Z

@Fatumayattani , @yashksaini-coder : Wonderful, great to hear. Appreciate your efforts.

We will review this PR in detail. Re-ran the CI/CD pipeline.

Since, it is an important module addition, wish to have feedback first from @acul71 , @lla-dane and @sumanjeet0012 .

We will discuss with @pacrob and have his review after discussing in tomorrow's maintainer's call.

acul71

PR #950 Review: Eclipse Attack Simulation Module

Summary

This PR introduces a Network Attack Simulation module for py-libp2p with a well-designed dual-layer architecture for Eclipse attack testing.

Recommendation: ✅ APPROVE with mods

Implementation Analysis

✅ What's Working Well:

Dual-layer architecture - Simulation + Real integration
Real integration tests - 3/3 tests pass with actual libp2p hosts
Comprehensive framework - Well-structured attack simulation foundation
Test coverage - 9/9 tests pass (6 simulation + 3 real integration)

✅ Architecture Design:

Simulation Layer: Fast framework validation with placeholder metrics (by design)
Real Integration Layer: Comprehensive attack simulation with actual libp2p components

Current Assessment

Test Coverage: 100% (9/9 tests pass)
Code Quality: Excellent structure with real integration
Documentation: Comprehensive README with clear usage examples
Performance: Fast simulation (0.40s) + Real integration (2.06s)
Functionality: ✅ COMPLETE - Both layers working as designed

Final Recommendation

✅ APPROVE but answer questions
and also wait is there a newsfragment?

(venv) luca@r17:~/PNL_Launchpad_Curriculum/Libp2p/py-libp2p$ l newsfragments/57
ls: cannot access 'newsfragments/57': No such file or directory

acul71 · 2025-09-24T20:33:43Z

+1. [Metrics and Analysis](#metrics-and-analysis)
+1. [Roadmap](#roadmap)
+1. [Eclipse Attack Flow](#eclipse-attack-flow)
+1. [Contributing](#contributing)


Why are all this 1s here not 1,2,3,....

Just noticed the auto-tab completion

acul71 · 2025-09-24T20:34:59Z

+    "honest_nodes": 10,
+    "malicious_nodes": 3,
+    "attack_intensity": 0.5,
+}


Did you try with different settings? are them handled ?

Some logs with different settings?
You may want to open a discussion page, and only put a link here, to not over bloat the PR

I will try with different settings and have the screenshot of the results in the Discussion page for this.

@acul71 I have done some more attack simulation test with multiple configs, and new test suite, shared the new disucssion here, #960

…lation' into feature/attack-simulation

for improved clarity and maintainability

…tack simulation

…store result as json

Fatumayattani · 2025-09-26T07:15:19Z

Thanks everyone for the feedback and contributions.

I’ve added the missing newsfragment.

Kudos to @yashksaini-coder for running additional tests, and Discussion #960 contains the comprehensive Eclipse attack simulation results.

Special thanks to @acul71 for the detailed review and @seetadev for coordinating the CI/CD workflow. Really appreciate everyone’s collaboration and support on this.

- Converted 143+ print statements across 4 test files to logging - Added logging.getLogger(__name__) to each file - Used appropriate log levels (debug for verbose, info for important) - Removed emoji decorations from test output - Removed if __name__ == '__main__' blocks from pure test files - All test files compile without errors Files updated: - test_attacks_simple.py: 45 prints → logger calls - test_real_eclipse_simulation.py: 26 prints → logger calls - test_multiple_scenarios.py: 14 prints → logger calls - test_runner.py: 50 prints → logger calls Addresses reviewer feedback: 'large number of print statements across several files' Ref: Discussion libp2p#929, PR libp2p#950

…x configuration

…lation modules

…sts for improved clarity and performance

- Resolves ModuleNotFoundError: No module named 'requests' - requests is required by libp2p/security/tls/autotls/acme.py and broker.py - types-requests (for type stubs) was already included but requests itself was missing - Version constraint: requests>=2.28.0

…orkflow

…k simulation workflow

pacrob · 2026-02-03T20:52:48Z

I see you've added a whole new attack-simulation.yml. I don't think that's necessary.

If you just move the folder tests/core/security/attack_simulation over so it is tests/examples/attack_simulation, it will get caught with the existing examples CI run.

yashksaini-coder · 2026-02-04T07:27:23Z

I see you've added a whole new attack-simulation.yml. I don't think that's necessary.

If you just move the folder tests/core/security/attack_simulation over so it is tests/examples/attack_simulation, it will get caught with the existing examples CI run.

Thanks for clarifying this, didn't know we can do that. Hopefully this resolves our ci-cd check issues.

pacrob · 2026-02-04T14:22:46Z

Thanks for clarifying this, didn't know we can do that. Hopefully this resolves our ci-cd check issues.

You've moved it to libp2p/examples. It still needs to be within tests to get caught, so libp2p/tests/examples/attack_simulation.

yashksaini-coder · 2026-02-06T20:59:33Z

Thanks for clarifying this, didn't know we can do that. Hopefully this resolves our ci-cd check issues.

You've moved it to libp2p/examples. It still needs to be within tests to get caught, so libp2p/tests/examples/attack_simulation.

Moved them to the tests/examples

pacrob · 2026-02-06T21:54:37Z

+   * - `ImportError: No module named libp2p.security.tls`
+     - TLS extras not installed
+     - Run `pip install "libp2p[tls]"`.


This can be deleted. There is no tls install target.

pacrob · 2026-02-06T21:56:07Z

    docs: make check-docs-ci
    interop: pytest -n auto --timeout=1200 {posargs:tests/interop}
    utils: pytest -n auto --timeout=1200 {posargs:tests/utils}
+    attack-simulation: pytest -v --timeout=180 --log-cli-level=WARNING {posargs:tests/core/security/attack_simulation}


this can be deleted - they're now part of the demos CI run.

pacrob

I've noted 2 places where code that is no longer relevant can be deleted. Once that is done, approved to merge.

yashksaini-coder · 2026-02-07T07:14:20Z

@pacrob I've removed the dead code which is no longer relevant, Hope now we have the PR ready for merge 👍🏼

seetadev · 2026-02-12T22:44:05Z

@pacrob and @acul71: Thank you so much for your review and feedback. Appreciate it.

@yashksaini-coder and @Fatumayattani : Looks great. This PR sets up a clean, well-structured foundation for network attack simulation in py-libp2p, with clear separation between malicious behavior, network construction, metrics, and scenarios. The module is thoughtfully organized, well documented, and easy to extend for future attack types.

All tests passing and the framework is solid. Thank you so much @yashksaini-coder and taking all the important steps for taking this PR to production.

Ready for merge. Great work!

Fatumayattani and others added 11 commits August 15, 2025 10:12

tls support

7a6b530

update tls docs

d0345b6

update tls support

7dd3469

update changes

bfbc389

tls support

a9b510e

tls support doc libp2p#700

6ea3016

Add tls-support.rst to docs toctree

77f4764

Merge branch 'main' into main

cc68f63

Replace asyncio with trio, fix newline, and run pre-commit checks on …

73d44ed

…TLS docs

Add initial Eclipse attack simulation module with tests

4f9eabe

Merge branch 'main' into feature/attack-simulation

d801a91

yashksaini-coder and others added 3 commits September 24, 2025 12:11

Merge branch 'libp2p:main' into feature/attack-simulation

c1df722

Merge branch 'main' into feature/attack-simulation

5691e6e

Refactor code for consistency and clarity; update README and configur…

6312c95

…ation files

Add real integration tests and metrics collection for Eclipse attack …

999d293

…simulation

acul71 approved these changes Sep 24, 2025

View reviewed changes

yashksaini-coder and others added 8 commits September 25, 2025 13:14

Merge branch 'main' into feature/attack-simulation

b46cdef

Linting errors resolved

44044f8

Merge remote-tracking branch 'refs/remotes/origin/feature/attack-simu…

efffe92

…lation' into feature/attack-simulation

Refactor real metrics collector and test structure

ba04a4f

for improved clarity and maintainability

Remove non-existent file

32483ac

Enhance type annotations and improve metrics collection in Eclipse at…

16708e3

…tack simulation

performed more test and test suite for multiple config scenarios and …

fd4d578

…store result as json

add newsfragment for PR libp2p#950 (Eclipse attack simulation module)

7004d94

yashksaini-coder and others added 13 commits January 27, 2026 12:25

Merge branch 'main' into feature/attack-simulation

89508da

Merge branch 'main' into feature/attack-simulation

d8a4714

Merge branch 'main' into feature/attack-simulation

97e945e

Merge branch 'main' into feature/attack-simulation

082816b

Add GitHub Actions workflow for attack simulation tests and update to…

d7a2119

…x configuration

Optimize sleep intervals for faster test execution across attack simu…

50e2ab9

…lation modules

Refactor logging and optimize sleep intervals in attack simulation te…

9c8722d

…sts for improved clarity and performance

Update upload-artifact action to v4 in attack simulation workflow

891d9b7

fix whitespaces and lint errors along with python-version for ci cd job

33f37e4

fix: add redis and factory-boy to dependencies in attack simulation w…

e76a389

…orkflow

fix: update dependency installation to include test packages in attac…

8b6ddfe

…k simulation workflow

Move to tests/examples

b44ab16

yashksaini-coder force-pushed the feature/attack-simulation branch from cec0633 to b44ab16 Compare February 4, 2026 17:01

Merge branch 'main' into feature/attack-simulation

436635b

pacrob reviewed Feb 6, 2026

View reviewed changes

pacrob approved these changes Feb 6, 2026

View reviewed changes

yashksaini-coder and others added 2 commits February 7, 2026 11:50

Merge branch 'main' into feature/attack-simulation

a5c14b8

remove code no longer relevant

8ae14d4

yashksaini-coder and others added 2 commits February 10, 2026 11:14

Merge branch 'main' into feature/attack-simulation

c39490e

Merge branch 'main' into feature/attack-simulation

8a949ef

seetadev merged commit b9fa02f into libp2p:main Feb 12, 2026
38 checks passed

Conversation

Fatumayattani commented Sep 23, 2025

What was wrong?

How was it fixed?

To-Do

Cute Animal Picture

Uh oh!

seetadev commented Sep 23, 2025

Uh oh!

yashksaini-coder commented Sep 23, 2025

Uh oh!

Fatumayattani commented Sep 24, 2025

Uh oh!

yashksaini-coder commented Sep 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

seetadev commented Sep 24, 2025

Uh oh!

acul71 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

PR #950 Review: Eclipse Attack Simulation Module

Summary

Implementation Analysis

✅ What's Working Well:

✅ Architecture Design:

Current Assessment

Final Recommendation

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Fatumayattani commented Sep 26, 2025

Uh oh!

pacrob commented Feb 3, 2026

Uh oh!

yashksaini-coder commented Feb 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pacrob commented Feb 4, 2026

Uh oh!

yashksaini-coder commented Feb 6, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pacrob left a comment

Choose a reason for hiding this comment

Uh oh!

yashksaini-coder commented Feb 7, 2026

Uh oh!

seetadev commented Feb 12, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

yashksaini-coder commented Sep 24, 2025 •

edited

Loading

acul71 left a comment •

edited

Loading

yashksaini-coder commented Feb 4, 2026 •

edited

Loading