feat: add receive interface information#35
feat: add receive interface information#35jclab-joseph wants to merge 1 commit intolibp2p:masterfrom
Conversation
|
I don’t understand this PR. Can you please explain what you’re trying to achieve? We avoid making changes to this repo unless absolutely necessary. |
|
Described at libp2p/go-libp2p#2660 (comment)
|
|
I don’t understand how that would work. What’s the address you’d advertise in that case? Can you give an example here? |
|
This is a fully working example. what has changed: https://github.com/jclab-joseph/libp2p-link-local-demo/pull/1/files After finding out the received interface using ifIndex or Zone, connect to |
|
This seems to be a fix for grandcat#51. Since we're only maintaining a fork of zeroconf to support some API changes, we won't merge this PR, unless the fix is upstreamed to the upstream repo. @jclab-joseph, please open a PR in the original repo, and once it's merged there, we can cherry-pick that commit onto our fork here. |

For libp2p/go-libp2p#2661
In the case of link-local address, the interface must be bound.
Include the received interface in a ServiceEntry.
Additionally, when using a bridge, slave interfaces should not be used:
https://github.com/libp2p/zeroconf/pull/35/files#diff-25a7cf08cc8fc8eb57475835cc380524de2fd1215cda9c6915132ae86dbd80a7R117-R121