adapt to the change in libpd's Oboe API#173
Conversation
|
@Ant1r Do you want to be in the libpd/Android group so you can manage this directly? I haven't done any Android dev so it would be great to increase the maintenance team. What do you think @joebowbeer? |
there's something reassuring about being forced to be reviewed :-) |
|
@danomatika if by "managing this directly" you mean bypassing PR approvals and overriding branch protection, I do not want to endorse that. I and @tkirshboim do appreciate what @Ant1r is doing and we can use more help. I'll confer with Tal just to make sure. I hope we can release the new Oboe support to maven central soon. |
joebowbeer
left a comment
There was a problem hiding this comment.
LGTM - when to merge?
I think it can be merged. Maybe it would need a version bump? |
|
I'll merge now unless you want to preserve the 1.4.1-SNAPSHOT. Ok? |
|
ok fine! |
I agree. |
This moves the libpd HEAD to the new libpd/libpd#423 proposal for supporting Oboe, which replaces libpd/libpd#422.
It implies a small change in PdAudio, replacing the abandoned
setRecordingDeviceId()andsetPlaybackDeviceId()PdBase's methods with theoptionsargument ofPdBase.openAudio().