Updating to libplctag core v2.6.12#454
Open
thaddeusbort wants to merge 2 commits intolibplctag:mainfrom
Open
Conversation
Collaborator
|
Thanks @thaddeusbort this is great - apologies for the delay. The change to unregister_logger looks good. Tim |
Author
|
I just reverted the binary changes. Let me know if you need anything else. Thanks. Ted |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I needed some of the changes from the newer version of libplctag so I updated this package with the latest binaries. I thought it could be useful for other people so I'm opening this pull request.
This PR updates the packaged libplctag binaries to the latest upstream release (v2.6.12).
Summary of changes:
plc_tag_unregister_logger()- the function no longer takes a parameter.This builds successfully and tests on my end behave correctly with the new binaries.
Let me know if you'd like any adjustments.