Skip to content

[ln882h] Fix flash write temp file access on Windows #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kuba2k2 merged 5 commits into from
Sep 19, 2025
Merged

[ln882h] Fix flash write temp file access on Windows #68

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5e3405f
[ln882h] reduce transfer baudrate to improve reliability
lamauny Jun 7, 2025
4c5f2e3
fix ln882x flash write on Windows platform
lamauny Jul 25, 2025
7850682
Merge branch 'libretiny-eu:master' into master
lamauny Jul 25, 2025
b2c0bbe
black reformat
lamauny Jul 25, 2025
480fa6f
Merge branch 'master' of https://github.com/lamauny/ltchiptool
lamauny Jul 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions ltchiptool/soc/ln882h/util/ln882htool.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,18 +207,17 @@ def flash_write(
self.command(f"startaddr 0x{offset:X}")

# Convert stream to temporary file before sending with YMODEM
tmp_file = NamedTemporaryFile()
with open(tmp_file.name, "wb") as f:
with NamedTemporaryFile(delete=False) as f:
f.write(stream.getbuffer())

self.command(f"upgrade", waitresp=False)
self.command(f"upgrade", waitresp=False)

self.push_timeout(3)
debug(f"YMODEM: transmitting to 0x{offset:X}")
if not self.ym.send([f.name], callback=callback):
self.change_baudrate(prev_baudrate)
self.pop_timeout()
raise RuntimeError("YMODEM transmission failed")
self.push_timeout(3)
debug(f"YMODEM: transmitting to 0x{offset:X}")
if not self.ym.send([f.name], callback=callback):
self.change_baudrate(prev_baudrate)
self.pop_timeout()
raise RuntimeError("YMODEM transmission failed")

self.link()

Expand Down