Support more texture formats with the OpenGL ES 2 renderer#15411
Open
ccawley2011 wants to merge 3 commits intolibsdl-org:mainfrom
Open
Support more texture formats with the OpenGL ES 2 renderer#15411ccawley2011 wants to merge 3 commits intolibsdl-org:mainfrom
ccawley2011 wants to merge 3 commits intolibsdl-org:mainfrom
Conversation
Collaborator
|
This PR is failing CI, FYI. |
Collaborator
|
Have you done any performance testing to verify that using the extension is faster than colorswapping in the shader? My impression was that they were equivalent in speed, and if so, there's no need to add complexity by checking for the extension. |
52ea295 to
73f1531
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This includes some of the changes from PR #9910, and also adds support for the
GL_EXT_texture_format_BGRA8888where available instead of swapping red and blue in the shader.