Add codepage detection for Windows 949-2000#9
Open
To-steak wants to merge 1 commit intolibyal:mainfrom
Open
Conversation
To-steak
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9 +/- ##
==========================================
- Coverage 90.03% 81.30% -8.74%
==========================================
Files 3 3
Lines 552 369 -183
Branches 101 67 -34
==========================================
- Hits 497 300 -197
- Misses 15 46 +31
+ Partials 40 23 -17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
joachimmetz
reviewed
Dec 3, 2025
| if( ( string[ string_index ] == (wchar_t) '9' ) | ||
| && ( string[ string_index + 1 ] == (wchar_t) '4' ) | ||
| && ( string[ string_index + 2 ] == (wchar_t) '9' ) | ||
| && ( string[ string_index + 3 ] == (wchar_t) '-' ) |
Member
There was a problem hiding this comment.
let's add _ as a separator as well
Member
|
thx for the proposed changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.