feat: add spectator chat for games#3131
Open
tom-anders wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a spectator chat entry point from the TV/watch game screen, wiring TV games into the existing chat UI/controller stack.
Changes:
- Adds a chat button to
TvScreenand introducesTvChatOptionsfor public spectator chat on watched games. - Extends
ChatBottomBarButtonto allow custom tap handling (while keeping the default navigation behavior). - Updates
ChatControllerto load initial chat lines for TV games viatvControllerProvider.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| lib/src/view/watch/tv_screen.dart | Adds chat button + state to manage watch behavior when navigating to chat. |
| lib/src/view/chat/chat_screen.dart | Makes ChatBottomBarButton optionally delegate its tap behavior to a caller-provided callback. |
| lib/src/model/tv/tv_controller.dart | Adjusts Flutter import (now material.dart). |
| lib/src/model/chat/chat_controller.dart | Adds TvChatOptions and loads TV chat initial messages + report resource mapping. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tom-anders
force-pushed
the
spectatorChat
branch
2 times, most recently
from
0410f04 to
e68be2f
Compare
Contributor
|
Sorry for the delay on this @tom-anders ; can you solve the conflict please? Thanks! |
Collaborator
Author
|
Rebased 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tv_chat.webm