feature/revision italicized moves left out for broadcast mainlines#3170
Open
MaartenD wants to merge 2 commits into
Open
Conversation
veloce
reviewed
May 13, 2026
| final state = container.read(ctrlProvider).requireValue; | ||
| final lastBranch = state.root.branchesOn(state.currentPath).lastOrNull; | ||
|
|
||
| expect(lastBranch?.isUserAdded, isTrue); |
Contributor
There was a problem hiding this comment.
I don't like this way of testing things. Instead of testing a value of the state we should always try to check the UI (that is the reason for widget testing).
So instead, find the corresponding move text in the UI and check that it has the italic style.
Contributor
Author
There was a problem hiding this comment.
Changed the test. If it's not what you want, please let me know. Still learning.
| final lastBranch = state.root.branchesOn(state.currentPath).lastOrNull; | ||
|
|
||
| // promoteAt only reorders children — isUserAdded stays false after promotion. | ||
| expect(lastBranch?.isUserAdded, isFalse); |
Contributor
Author
There was a problem hiding this comment.
Changed the test. If it's not what you want, please let me know. Still learning.
| final state = container.read(ctrlProvider).requireValue; | ||
| final lastBranch = state.root.branchesOn(state.currentPath).lastOrNull; | ||
|
|
||
| expect(lastBranch?.isUserAdded, isFalse); |
Contributor
Author
There was a problem hiding this comment.
Changed the test. If it's not what you want, please let me know. Still learning.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made moves added to a broadcasts game italic.
Also provided tests.
Moves-entered-after-broadcasts-game-in-italic.mp4
Fixes: #3162