Conversation
Change TempDir default from $env:TEMP to build/ in the repo root, and InstallDir from C:\quantlib-build\install to install/ in the repo root. This lets you inspect patched QuantLib sources after a local build. CI is unaffected since the workflow passes explicit paths. https://claude.ai/code/session_01EVB6yo51Ug6uCWAPSfUgwz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updated the Build-QuantLibDLL.ps1 script to use repository-relative paths for default build and install directories instead of hardcoded absolute paths, making the build process more portable and allowing users to inspect patched sources locally.
Key Changes
InstallDirfromC:\quantlib-build\installtoinstall/in the repository rootTempDirfrom$env:TEMP\quantlib-dll-buildtobuild/in the repository rootImplementation Details
Join-Path (Split-Path $PSScriptRoot)to construct paths relative to the repository rootbuild\QuantLib-<version>\after the build completeshttps://claude.ai/code/session_01EVB6yo51Ug6uCWAPSfUgwz