Suppress C4251 warnings in QuantLib DLL builds#5
Merged
Conversation
Inject `add_compile_options(/wd4251)` into cmake/Platform.cmake during patching. C4251 fires for every class member using STL types in a DLL-exported class; with CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS=ON these warnings are harmless noise that drowns out real diagnostics. https://claude.ai/code/session_012RnYmE4NKFQ4NjtbkQANzF
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updated the QuantLib DLL build script to suppress C4251 compiler warnings that occur when STL types are used in DLL-exported class members.
Changes
Platform.cmakepatch inBuild-QuantLibDLL.ps1to add a compile option that suppresses the C4251 warning (/wd4251) in addition to removing the FATAL_ERROR that blocks DLL buildsDetails
The C4251 warning is a common issue when building DLLs with MSVC, as it warns about STL container types being used in exported class members. By adding
add_compile_options(/wd4251)to the patchedPlatform.cmake, the build process will no longer emit these warnings, resulting in cleaner build output while maintaining the functionality of DLL builds on MSVC.https://claude.ai/code/session_012RnYmE4NKFQ4NjtbkQANzF