Conversation
…ls, improve build diagnostics - Patch gaussiancopulapolicy.hpp: add QL_EXPORT to private static const members (density_, cumulative_) that aren't auto-exported by CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS - Patch primitivepolynomials.hpp: add QL_EXPORT to extern PrimitivePolynomials array and include qldefines.hpp - Split CMake build into separate library and test suite targets with per-target log capture for better error diagnosis - Add "Show build errors" CI step to display build logs on failure - Fix test suite executable name: quantlib-test-suite.exe (not ql_test_suite.exe) https://claude.ai/code/session_01Pe2NhovoMN1DaU6vjJ1gjj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extended the QuantLib DLL build script to apply two additional patches for proper symbol export annotations, and improved build logging and error reporting.
Key Changes
Added two new export patches to enable DLL builds:
gaussiancopulapolicy.hpp- Annotate static const members (density_andcumulative_) withQL_EXPORTprimitivepolynomials.hpp- Annotate extern array (PrimitivePolynomials) withQL_EXPORTand injectqldefines.hppinclude if missingImproved build process:
build-library.log,build-testsuite.log) for better diagnostics$BuildTestsparameterEnhanced CI/CD error diagnostics:
Minor fixes:
ql_test_suite.exetoquantlib-test-suite.exeto match actual output nameImplementation Details
The new patches follow the same pattern as existing ones, using PowerShell string replacement to inject
QL_EXPORTannotations. Theprimitivepolynomials.hpppatch includes a check to avoid duplicate includes ofqldefines.hpp.https://claude.ai/code/session_01Pe2NhovoMN1DaU6vjJ1gjj