Add -RunTests flag to execute quantlib-test-suite.exe after build#8
Merged
Add -RunTests flag to execute quantlib-test-suite.exe after build#8
Conversation
- Add -RunTests parameter to Build-QuantLibDLL.ps1 (implies -BuildTests) - After build, locate the test exe and run it with the DLL directory on PATH - Validate exit code 0 and "*** No errors detected" in output - Enable tests by default in the workflow (both push/PR and workflow_dispatch) - Add run_tests input to workflow_dispatch for manual control https://claude.ai/code/session_01Pe2NhovoMN1DaU6vjJ1gjj
* Fix PrimitivePolynomials export patch to match actual header format The primitivepolynomials.hpp declaration uses a multi-line extern "C" block, so "extern" and "const long *const PrimitivePolynomials" are on separate lines. The previous .Replace() looked for them as a contiguous string and silently failed to match. Match just "const long *const PrimitivePolynomials" instead, and guard with a QL_EXPORT check to prevent double application. https://claude.ai/code/session_01VaKuQu3KJqit4LpCz2ruzS * Fix benchmark install failure: use correct CMake option name QuantLib v1.41 does not have a QL_BUILD_BENCHMARK option (it was silently ignored). The correct option is QL_INSTALL_BENCHMARK, which controls whether cmake --install tries to install quantlib-benchmark.exe. Without this fix, the install step fails when BuildTests is enabled because the benchmark exe is never built (only ql_test_suite target is built) but the install rule still expects it. https://claude.ai/code/session_01VaKuQu3KJqit4LpCz2ruzS * Disable run_tests by default in CI workflow Change the run_tests input default from true to false and fix the logic so push/PR triggers (where the input is empty) also skip tests. Tests can still be run via workflow_dispatch by setting run_tests=true. https://claude.ai/code/session_01VaKuQu3KJqit4LpCz2ruzS --------- Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://claude.ai/code/session_01Pe2NhovoMN1DaU6vjJ1gjj