Skip to content

feat(widget): surface route settings on main page with dedicated pages#792

Draft
effie-ms wants to merge 4 commits into
mainfrom
feat/advanced-mode-settings
Draft

feat(widget): surface route settings on main page with dedicated pages#792
effie-ms wants to merge 4 commits into
mainfrom
feat/advanced-mode-settings

Conversation

@effie-ms

@effie-ms effie-ms commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Which Linear task is linked to this PR?

N/A

Why was it implemented this way?

Brings the advanced-mode settings design from the 2.0 prototype into the widget:

  • Quick Settings strip on the main page, shown only for the advanced split tabs (swap-advanced / bridge-advanced): compact rows (title sized like the "Send"/"Receive" input-card labels) showing live values for the active sub-mode — Swap: Route type · Exchanges · Max slippage; Bridge: Route priority · Exchanges · Bridges · Max slippage. Each row navigates to its setting.
  • Dedicated settings sub-pages for Route type, Route priority, and Slippage (previously inline accordion cards), matching the prototype. Bridges/Exchanges already had their own pages. Route priority offers Best Return / Fastest / Cheapest; slippage is a preset selector (Auto / 0.5% / 1% / 3% / Custom).
  • New routeType setting (All / Private).

Gating is purely tab-key driven (advancedNavigationTabKeys) on the navigation-tabs infrastructure already merged to main, so this PR targets main and has no dependency on other feature branches.

⚠️ Open items before merge

  • routeType is display-only — the SDK has no route-type/privacy param, so it currently does not affect routing (TODO in types.ts). Consider gating the option until wired.
  • "Best Return" maps to the deprecated RECOMMENDED order; needs a live-API smoke test.
  • New i18n keys are English-only so far.
  • No changeset yet.

Visual showcase (Screenshots or Videos)

N/A

Checklist before requesting a review

  • I have performed a self-review and testing of my code.
  • This pull request is focused and addresses a single problem.
  • If this PR modifies the Widget API or adds new features that require documentation, I have updated the documentation in the public-docs repository.

@changeset-bot

changeset-bot Bot commented Jun 16, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 8309cc6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@effie-ms effie-ms self-assigned this Jun 16, 2026
@effie-ms effie-ms force-pushed the feat/private-tab-mode branch 2 times, most recently from 572513c to a80d82f Compare June 18, 2026 08:45
@effie-ms effie-ms force-pushed the feat/private-tab-mode branch from a80d82f to 65f2d16 Compare June 22, 2026 11:20
@effie-ms effie-ms force-pushed the feat/advanced-mode-settings branch from 2e18856 to 6f66b1a Compare June 22, 2026 15:05
@effie-ms effie-ms changed the base branch from feat/private-tab-mode to main June 22, 2026 15:05
@github-actions

github-actions Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

✅ E2E Dev Smoke — passing

Check Result
Dev server start (pnpm dev) ✅ started
Smoke tests ✅ passed

4 passed · 0 failed · 0 skipped · 13s

View run

@github-actions

github-actions Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

E2E Playground results

passed  158 passed

Details

stats  158 tests across 10 suites
duration  2 minutes, 13 seconds
commit  8309cc6

📥 Download full HTML report (open the run → Artifacts → playwright-report)

@github-actions

github-actions Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

E2E Examples — all passed

All examples passed in the latest run.

@effie-ms effie-ms force-pushed the feat/advanced-mode-settings branch from 6f66b1a to 14cf8cf Compare June 22, 2026 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant