feat(widget): surface route settings on main page with dedicated pages#792
Draft
effie-ms wants to merge 4 commits into
Draft
feat(widget): surface route settings on main page with dedicated pages#792effie-ms wants to merge 4 commits into
effie-ms wants to merge 4 commits into
Conversation
|
572513c to
a80d82f
Compare
a80d82f to
65f2d16
Compare
2e18856 to
6f66b1a
Compare
Contributor
✅ E2E Dev Smoke — passing
4 passed · 0 failed · 0 skipped · 13s |
Contributor
E2E Playground resultsDetails
📥 Download full HTML report (open the run → Artifacts → |
Contributor
E2E Examples — all passedAll examples passed in the latest run. |
6f66b1a to
14cf8cf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Linear task is linked to this PR?
N/A
Why was it implemented this way?
Brings the advanced-mode settings design from the 2.0 prototype into the widget:
swap-advanced/bridge-advanced): compact rows (title sized like the "Send"/"Receive" input-card labels) showing live values for the active sub-mode — Swap: Route type · Exchanges · Max slippage; Bridge: Route priority · Exchanges · Bridges · Max slippage. Each row navigates to its setting.routeTypesetting (All / Private).Gating is purely tab-key driven (
advancedNavigationTabKeys) on the navigation-tabs infrastructure already merged tomain, so this PR targetsmainand has no dependency on other feature branches.routeTypeis display-only — the SDK has no route-type/privacy param, so it currently does not affect routing (TODO intypes.ts). Consider gating the option until wired.RECOMMENDEDorder; needs a live-API smoke test.Visual showcase (Screenshots or Videos)
N/A
Checklist before requesting a review