Fix/mas installer identity#26
Merged
Merged
Conversation
The mas.identity was set to the full "Apple Distribution: ..." string. electron-builder reuses mas.identity as the search qualifier for the installer cert too, and that string can never match a "3rd Party Mac Developer Installer" line, so the pkg step failed with "Cannot find valid identity". Use the bare "Julia Kafarska (8Y2UTZ2NBZ)" qualifier: the app still resolves to Apple Distribution (tried first for MAS) and the installer resolves to the 3rd Party cert. verify-mas-build.mjs: only require com.apple.security.inherit on Mach-O executables (helpers, login helper, ffmpeg) that spawn as their own process. Dylibs/frameworks/.node bundles load in-process and must not carry it — a valid team signature is enough. Also skip symlinks when walking the bundle so the framework's Versions/Current alias isn't traversed back into Versions/A.
- Add IdentityDialog component (optional name/email → PostHog person properties; missing from the prior commit, which broke App.tsx's import) - TTS: self-adapting ONNX execution-provider selection with hard CPU fallback (OUT_LOUD_ACCEL=auto opts into GPU). Default stays CPU — the int8 model leaves GPU EPs ~1% node coverage, so CPU is faster. Dedupe the two session-creation paths into a single cached ensureSession. - Bump version to 2.0.1 for App Store resubmission.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Resolves the three App Store review rejections for Out Loud 2.0 and ships a few related improvements, bumping to 2.0.1. Removes the external "Buy Me a Coffee" donation link (3.1.1), drops the unused com.apple.security.network.server entitlement and gates the local extension HTTP server off in MAS builds (2.4.5(i)), and adds an application Window menu so a closed window can be reopened (Guideline 4). Also adds an optional name/email capture that maps to PostHog person properties, an MP3/WAV download format dropdown, and self-adapting ONNX GPU execution-provider selection with CPU fallback (CPU stays the default). Builds on the earlier MAS installer-signing/verifier fixes already on this branch.
Why
App Review rejected 2.0.0 (submission 3ae12404-…) on guidelines 3.1.1, 2.4.5(i), and 4. Each change maps directly to a rejection reason:
The identity capture (opt-in, post-export soft prompt) and MP3 export are product asks. The GPU EP work is investigative: the embedded model is int8-quantized, so GPU providers only cover ~1% of the graph — CPU is kept as the default, with the machinery in place (OUT_LOUD_ACCEL=auto) for a future non-quantized model.
Checklist