Skip to content

SAM3: Prevent using transformers 5.10#9

Merged
MalteEbner merged 1 commit into
mainfrom
malte-disallow-broken-transformers-version
Jun 4, 2026
Merged

SAM3: Prevent using transformers 5.10#9
MalteEbner merged 1 commit into
mainfrom
malte-disallow-broken-transformers-version

Conversation

@MalteEbner

@MalteEbner MalteEbner commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

What has changed and why?

Prevent using transformers 5.10, which is broken. See huggingface/transformers#46402

How has it been tested?

Manually

Did you update Readme.md and plugins.toml?

  • Yes
  • Not needed

Updated the transformers dependency constraint in plugins/sam3_segmentation/pyproject.toml from transformers>=4.57.2 to transformers>=4.57.2,<5.10 to prevent use of the broken v5.10 release. Added inline comments referencing the upstream Hugging Face issue for context.

@coderabbitai

coderabbitai Bot commented Jun 4, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: df0678f8-0852-43fc-b71c-7b5ea17cc542

📥 Commits

Reviewing files that changed from the base of the PR and between eea97df and 649f61b.

📒 Files selected for processing (1)
  • plugins/sam3_segmentation/pyproject.toml

📝 Walkthrough

Walkthrough

The SAM3 segmentation plugin's transformers dependency constraint is updated from an unconstrained lower bound (>=4.57.2) to an upper-bounded range (>=4.57.2,<5.10). Inline comments explain the constraint rationale with a reference to a Hugging Face issue.

Changes

Transformers Dependency Constraint

Layer / File(s) Summary
Transformers version upper bound
plugins/sam3_segmentation/pyproject.toml
The transformers dependency now specifies an upper bound constraint (<5.10) with inline comments documenting the incompatibility reason.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: preventing use of transformers version 5.10.
Description check ✅ Passed The description follows the template structure with all required sections completed: what changed and why, testing approach, and documentation update status.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch malte-disallow-broken-transformers-version

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@MalteEbner

Copy link
Copy Markdown
Contributor Author

/review

@MalteEbner MalteEbner merged commit f793b7d into main Jun 4, 2026
5 checks passed
@MalteEbner MalteEbner deleted the malte-disallow-broken-transformers-version branch June 4, 2026 08:46
@CLAassistant

CLAassistant commented Jun 4, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants