Skip to content

Allow setting alias in config#67

Merged
tnull merged 1 commit into
lightningdevkit:mainfrom
benthecarman:alias-config
Jul 28, 2025
Merged

Allow setting alias in config#67
tnull merged 1 commit into
lightningdevkit:mainfrom
benthecarman:alias-config

Conversation

@benthecarman

Copy link
Copy Markdown
Collaborator

No description provided.

@ldk-reviews-bot

ldk-reviews-bot commented Jul 22, 2025

Copy link
Copy Markdown

👋 I see @joostjager was un-assigned.
If you'd like another reviewer assignment, please click here.

@tnull tnull requested review from tnull and removed request for joostjager July 23, 2025 08:09

@tnull tnull left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good, two comments.

Also, while the change is trivial in this case, proper commit messages and PR descriptions would be appreciated. 😛

Comment thread ldk-server/src/util/config.rs Outdated
Comment thread ldk-server/src/util/config.rs

@tnull tnull left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tnull tnull merged commit ae2535f into lightningdevkit:main Jul 28, 2025
7 checks passed
@benthecarman benthecarman deleted the alias-config branch July 28, 2025 08:52
rsafier pushed a commit to rsafier/ldk-server that referenced this pull request Apr 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants