Skip to content

Add splicing RPCs and CLI commands#73

Merged
tnull merged 1 commit into
lightningdevkit:mainfrom
jkczyz:2025-10-splicing
Dec 11, 2025
Merged

Add splicing RPCs and CLI commands#73
tnull merged 1 commit into
lightningdevkit:mainfrom
jkczyz:2025-10-splicing

Conversation

@jkczyz

@jkczyz jkczyz commented Oct 30, 2025

Copy link
Copy Markdown
Contributor

Based on #72.

@ldk-reviews-bot

ldk-reviews-bot commented Oct 30, 2025 •
edited
Loading

Copy link
Copy Markdown

👋 Thanks for assigning @tnull as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@jkczyz jkczyz self-assigned this Oct 30, 2025
@tnull tnull self-requested a review October 30, 2025 17:39
@ldk-reviews-bot

ldk-reviews-bot commented Nov 3, 2025

Copy link
Copy Markdown

🔔 1st Reminder

Hey @tnull! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

@ldk-reviews-bot

ldk-reviews-bot commented Nov 5, 2025

Copy link
Copy Markdown

🔔 2nd Reminder

Hey @tnull! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

@ldk-reviews-bot

ldk-reviews-bot commented Nov 8, 2025

Copy link
Copy Markdown

🔔 3rd Reminder

Hey @tnull! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

@ldk-reviews-bot

ldk-reviews-bot commented Nov 10, 2025

Copy link
Copy Markdown

🔔 4th Reminder

Hey @tnull! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

@ldk-reviews-bot

ldk-reviews-bot commented Nov 12, 2025

Copy link
Copy Markdown

🔔 5th Reminder

Hey @tnull! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

@ldk-reviews-bot

ldk-reviews-bot commented Nov 15, 2025

Copy link
Copy Markdown

🔔 6th Reminder

Hey @tnull! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

@ldk-reviews-bot

ldk-reviews-bot commented Nov 17, 2025

Copy link
Copy Markdown

🔔 7th Reminder

Hey @tnull! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

tnull
tnull reviewed Nov 17, 2025
View reviewed changes
Comment thread Cargo.lock
@jkczyz jkczyz force-pushed the 2025-10-splicing branch 4 times, most recently from 8eb5cb1 to 19f6023 Compare December 10, 2025 15:01
@jkczyz jkczyz marked this pull request as ready for review December 10, 2025 15:02
@jkczyz jkczyz requested a review from tnull December 10, 2025 15:02
tnull
tnull previously approved these changes Dec 11, 2025
View reviewed changes

@tnull tnull left a comment •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One non-blocking nit, otherwise LGTM.

Feel free to land as-is.

Comment thread ldk-server/src/api/splice_channel.rs Outdated
.map_err(|_| {
LdkServerError::new(
InvalidRequestError,
"Address is not valid for LdkServer's configured network.".to_string(),

@tnull tnull Dec 11, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:

Suggested change
"Address is not valid for LdkServer's configured network.".to_string(),
"Address is not valid for the configured network.".to_string(),

(or "LDK Server").

@jkczyz jkczyz requested a review from tnull December 11, 2025 15:34
@jkczyz

jkczyz commented Dec 11, 2025

Copy link
Copy Markdown
Contributor Author

One non-blocking nit, otherwise LGTM.

Feel free to land as-is.

Fixed, though looks it will need another approval.

@tnull tnull merged commit 2c24f68 into lightningdevkit:main Dec 11, 2025
7 checks passed
rsafier pushed a commit to rsafier/ldk-server that referenced this pull request Apr 20, 2026
@tnull
Merge pull request lightningdevkit#73 from jkczyz/2025-10-splicing
f05824e 
Add splicing RPCs and CLI commands
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tnull tnull tnull approved these changes

Assignees

@jkczyz jkczyz

Labels

None yet

Projects

Weekly Goals
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jkczyz @ldk-reviews-bot @tnull