Create default data directory at ~/.ldk-server #96
Conversation
|
👋 Thanks for assigning @tnull as a reviewer! |
tnull
left a comment
tnull
left a comment
There was a problem hiding this comment.
Makes sense, some initial comments.
ldk-server/src/main.rs
Outdated
| Some(path) => { | ||
| // Add network subdirectory for test networks to make sure we don't overwrite | ||
| // data when switching between networks. | ||
| if config_file.network != Network::Bitcoin { |
There was a problem hiding this comment.
Hmm, doing it like that might mean creating one seed per network also. Is this intentional, or should we still create a single seed for all networks at the top level?
There was a problem hiding this comment.
Yeah I had similar thoughts for this and the TLS key/cert. I can go either way on it. Code was simpler this way and more separation between networks can't hurt, so that's why I did this.
There was a problem hiding this comment.
Hmm, I think having multiple seeds is a bit confusing. If we already match the Bitcoin Core pattern with the 'mainnet is main folder other networks have sub-folders' we might also follow the pattern there, i.e., you have a single seed across networks. Same goes for the TLS certs/keys, and really any other 'general' files, IMO.
There was a problem hiding this comment.
done, made api_key individual to the network so you don't have to give up access to mainnet if you just want to give access to a test network
|
I took over #69 and about to reopen it but I see this is taking a different direction. I'll reopen and leave it in draft for now till this lands to reduce the conflicts. |
benthecarman
force-pushed
the
default-data-dir
branch
2 times, most recently
from
2ce8622 to
1bcd9f2
Compare
benthecarman
force-pushed
the
default-data-dir
branch
3 times, most recently
from
3bcf2cc to
29dfd67
Compare
Previously, the daemon required a config file path argument and the CLI required explicit --api-key and --tls-cert flags. Now both default to reading from ~/.ldk-server/config.toml, so you can just run the daemon and CLI without having to specify any flags. We make sure to separate out data by network so we don't conflict anywhere and accidentally lose anything important
benthecarman
force-pushed
the
default-data-dir
branch
from
29dfd67 to
639655c
Compare
4 participants
Previously, the daemon required a config file path argument and the CLI required explicit --api-key and --tls-cert flags. Now both default to reading from ~/.ldk-server/config.toml, so you can just run the daemon and CLI without having to specify any flags.
We make sure to separate out data by network so we don't conflict anywhere and accidentally lose anything important