Expose the channel via which we received a payment

[tnull]

Fixes #1800.
Based on #1855.

Previously the user had a hard time understanding via which channel we received some funds. In this PR, we therefore expose the channel_id and user_channel_id of the last hop in the PaymentReceived event.

[tnull]

Currently in draft. Will also expose the current number of confirmations in ChannelDetails as requested in #1800, and will look into whether we want to expose the channel ids also in other event types.

[TheBlueMatt]

Nice! Thanks. Let us know when you're ready for more review but the draft code basically LGTM.

[tnull]

Nice! Thanks. Let us know when you're ready for more review but the draft code basically LGTM.

I now exposed the number of confirmations via ChannelDetails. Should be ready for review.

I also explored exposing the channel ids in PaymentClaimed, however, I'm not sure if we want to go this way since we'd need to collect all last hops of MPP payments, which we'd probably don't want to do via a simple unsorted Vec. So if we want to do it, it should probably be a map showing which parts were claimed over which channel? Then again, this seems overly complicated for not that much benefit over the information provided in PaymentReceived. Any opinion whether we want to also expose them in PaymentClaimed?

[codecov-commenter]

Codecov Report

Base: 90.72% // Head: 90.70% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (3625608) compared to base (64b9e83).
Patch coverage: 97.05% of modified lines in pull request are covered.

❗ Current head 3625608 differs from pull request most recent head b1b3666. Consider uploading reports for the commit b1b3666 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1856      +/-   ##
==========================================
- Coverage   90.72%   90.70%   -0.02%     
==========================================
  Files          91       91              
  Lines       47999    48042      +43     
  Branches    47999    48042      +43     
==========================================
+ Hits        43546    43578      +32     
- Misses       4453     4464      +11     

Impacted Files	Coverage Δ
lightning/src/util/events.rs	25.97% <71.42%> (+0.35%)	⬆️
lightning/src/ln/chanmon_update_fail_tests.rs	97.59% <100.00%> (+<0.01%)	⬆️
lightning/src/ln/channel.rs	88.84% <100.00%> (+0.01%)	⬆️
lightning/src/ln/channelmanager.rs	86.37% <100.00%> (+0.02%)	⬆️
lightning/src/ln/functional_test_utils.rs	93.73% <100.00%> (+0.01%)	⬆️
lightning/src/ln/functional_tests.rs	97.01% <100.00%> (-0.07%)	⬇️
lightning/src/ln/reorg_tests.rs	100.00% <100.00%> (ø)
lightning/src/routing/router.rs	91.73% <100.00%> (+<0.01%)	⬆️
lightning-net-tokio/src/lib.rs	76.73% <0.00%> (-0.31%)	⬇️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[valentinewallace]

Basically LGTM

[valentinewallace]

LGTM after squash

[tnull]

LGTM after squash

Squashed commits without further changes. Happy to rebase again though, if we want to land #1766 before this.

[TheBlueMatt]

Needs rebase now.

[tnull]

Rebased on main.

[valentinewallace]

LGTM after squash :)

[TheBlueMatt]

Yes, please squash :)

[tnull]

Squashed without further changes.